Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fileupload): improve spacing where image preview doesn't exist #15731

Merged

Conversation

dalenguyen
Copy link
Contributor

Defect Fixes

Fix #15730

Before

image

After

image

Copy link

vercel bot commented May 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
primeng ⬜️ Ignored (Inspect) Visit Preview May 28, 2024 9:16pm

@dalenguyen
Copy link
Contributor Author

For the spacing on mobile. Not sure what is the best approach for it 🤔

image

Should we target .p-fileupload .p-fileupload-buttonbar .p-button, but there're a lot of them:

 .p-fileupload .p-fileupload-buttonbar .p-button {
    margin-right: 0.5rem;
    // add margin bottom???
    margin-bottom: 0.5rem;
  }
image

@dalenguyen
Copy link
Contributor Author

I'm good with merging the current one and having the button spacing in another PR if you see it's ok :)

@cetincakiroglu
Copy link
Contributor

Hi @dalenguyen,

Good catch, thanks for the effort and support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FileUpload: Improve styling for mobile and not image files preview
2 participants